Refactor oauth2-resource-server deprecated calls#18500
Closed
paulvas wants to merge 1 commit into
Closed
Conversation
…ntrospector to use builder pattern for instantiation Closes spring-projectsgh-18436 Signed-off-by: paulvas <paulvas@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Thank you for the pull request, but we need to keep testing methods even if they are using deprecated methods within Spring Security (we still want to test deprecated methods). I've added additional guidance around this to the parent issue:
With this in mind, I'm closing this pull request. However, if you are able to help out with the new guidance I'd love to see a new pull request! |
rwinch
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors tests for both
SpringOpaqueTokenIntrospectorandSpringReactiveOpaqueTokenIntrospectorto use their new builder APIs instead of direct constructors. It also updates tests to reflect changes in how client credentials encoding is handled, ensuring that special characters are now supported. Additionally, the tests for constructor argument validation have been updated for consistency with the new builder pattern.Builder API migration:
withIntrospectionUri,clientId,clientSecret,build) in all relevant test cases for bothSpringOpaqueTokenIntrospectorandSpringReactiveOpaqueTokenIntrospector. [1] [2] [3] [4]Constructor validation updates:
nullinstead of empty string forclientIdin the reactive introspector. [1] [2]Client credentials encoding changes: